hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2370) Made comment more accurate in AppSchedulingInfo.java
Date Wed, 30 Jul 2014 04:26:38 GMT

    [ https://issues.apache.org/jira/browse/YARN-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078870#comment-14078870
] 

Hadoop QA commented on YARN-2370:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12658574/YARN-2370.0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4478//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4478//console

This message is automatically generated.

> Made comment more accurate in AppSchedulingInfo.java
> ----------------------------------------------------
>
>                 Key: YARN-2370
>                 URL: https://issues.apache.org/jira/browse/YARN-2370
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0
>            Reporter: Wenwu Peng
>            Assignee: Wenwu Peng
>            Priority: Trivial
>         Attachments: YARN-2370.0.patch
>
>
> in method allocateOffSwitch of AppSchedulingInfo.java, only invoke update OffRack request,
 the comment should be "Update cloned OffRack requests for recovery" not "Update cloned RackLocal
 and OffRack requests for recover" 
> {code} 
> // Update cloned RackLocal and OffRack requests for recovery
>  resourceRequests.add(cloneResourceRequest(offSwitchRequest));
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message