hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-2346) Add a 'status' command to yarn-daemon.sh
Date Sat, 26 Jul 2014 23:10:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075508#comment-14075508
] 

Allen Wittenauer edited comment on YARN-2346 at 7/26/14 11:10 PM:
------------------------------------------------------------------

In order to make this work reliably, it's a significant refactoring of how daemons launch.
 All of that refactoring has already been done in HADOOP-9902.  

Specifically, pid handling has to get moved to the yarn, hdfs, and mapred commands from the
*-daemon.sh commands.  For example, if one runs 'yarn resourcemanager' it will not generate
a pid file.  This in turn means that if one were to modify only yarn-daemon.sh,  the status
subcommand will be giving incorrect information because it doesn't see a pid file.  Now one
could try to suss out the Java process running the RM, but that's a bit to fragile for my
tastes.  Another option would be to just do even more copypasta in the shell code, but that's
just making bad code even worse.

There's been talk of backporting HADOOP-9902 to branch-2, so it is worthwhile to take a wait
and see approach, especially given the door is pretty shut on getting anything more into 2.5.


was (Author: aw):
In order to make this work reliably, it's a significant refactoring of how daemons launch.
 All of that refactoring has already been done in HADOOP-9902.  

Specifically, pid handling has to get moved to the yarn, hdfs, and mapred commands from the
*-daemon.sh commands.  For example, if one runs 'yarn resourcemanager' it will not generate
a pid file.  This in turn means that if one were to modify only yarn-daemon.sh,  the status
subcommand will be giving incorrect information because it doesn't see a pid file.  Now one
could try to suss out the Java process running the RM, but that's a bit to fragile for my
tastes.  Another option would be to just do even more copypasta in the shell code, but that's
just making bad code even worse.

There's been talking of backporting HADOOP-9902 to branch-2, so it is worthwhile to take a
wait and see approach, especially given the door is pretty shut on getting anything more into
2.5.

> Add a 'status' command to yarn-daemon.sh
> ----------------------------------------
>
>                 Key: YARN-2346
>                 URL: https://issues.apache.org/jira/browse/YARN-2346
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0, 2.3.0, 2.2.1, 2.4.0, 2.4.1
>            Reporter: Nikunj Bansal
>            Assignee: Allen Wittenauer
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Adding a 'status' command to yarn-daemon.sh will be useful for finding out the status
of yarn daemons.
> Running the 'status' command should exit with a 0 exit code if the target daemon is running
and non-zero code in case its not.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message