hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2295) Refactor YARN distributed shell with existing public stable API
Date Mon, 21 Jul 2014 16:34:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068735#comment-14068735
] 

Jian He commented on YARN-2295:
-------------------------------

patch looks good overall, one comment:
 we can have the newInstance include the following setResource method also.
{code}
        LocalResource shellRsrc = LocalResource.newInstance(null,
          LocalResourceType.FILE, LocalResourceVisibility.APPLICATION,
          shellScriptPathLen, shellScriptPathTimestamp);
        try {
          shellRsrc.setResource(ConverterUtils.getYarnUrlFromURI(new URI(
            renamedScriptPath.toString())));
        } 
{code}

> Refactor YARN distributed shell with existing public stable API
> ---------------------------------------------------------------
>
>                 Key: YARN-2295
>                 URL: https://issues.apache.org/jira/browse/YARN-2295
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: TEST-YARN-2295-071514.patch, YARN-2295-071514-1.patch, YARN-2295-071514.patch
>
>
> Some API calls in YARN distributed shell have been marked as unstable and private. Use
existing public stable API to replace them, if possible. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message