hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhihai xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2254) change TestRMWebServicesAppsModification to support FairScheduler.
Date Sun, 13 Jul 2014 04:40:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059990#comment-14059990
] 

zhihai xu commented on YARN-2254:
---------------------------------

Karthik- Sorry, I am busy last several days. I get time to work on this issue today.
Your suggestion is really good, I already see the benefits now.
A new test (testAppSubmit) is added recently(after I submit patch on 07/04).
This new test(testAppSubmit) is failed with FairScheduler at "assertEquals(queueName, app.getQueue());".
So if someone test  TestRMWebServicesAppsModification with Fair scheduler as default scheduler,
 it will fail at testAppSubmit.
Now I fix this issue in my new patch YARN-2254.001.patch.
Also based on your suggestion. in my new patch YARN-2254.001.patch, I changed TestRMWebServicesAppsModification
to make the test parametrized and run it on both CapacityScheduler and FairScheduler.
In the future, if someone add new test cases to TestRMWebServicesAppsModification, same problem
won't happen any more, because this unit test will run on FairScheduler also.

> change TestRMWebServicesAppsModification to support FairScheduler.
> ------------------------------------------------------------------
>
>                 Key: YARN-2254
>                 URL: https://issues.apache.org/jira/browse/YARN-2254
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>              Labels: test
>         Attachments: YARN-2254.000.patch, YARN-2254.001.patch
>
>
> TestRMWebServicesAppsModification skips the test, if the scheduler is not CapacityScheduler.
> change TestRMWebServicesAppsModification to support both CapacityScheduler and FairScheduler.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message