hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2244) FairScheduler missing handling of containers for unknown application attempts
Date Fri, 18 Jul 2014 05:47:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066089#comment-14066089
] 

Karthik Kambatla commented on YARN-2244:
----------------------------------------

Latest patch looks good. A couple of nits:
# The 80 chars limit doesn't apply to imports - can we get them one per line?
{code}
+import org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity
+    .CapacityScheduler;
+import org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica
+    .FiCaSchedulerApp;
{code}
# Limit the following line to 80 chars. 
{code}
+    SchedulerApplicationAttempt application = getCurrentAttemptForContainer(containerId);
{code}
# Unused imports in CapacityScheduler, FairScheduler, FifoScheduler.
# Few comments on the do-while loop in the test:
{code}
    int waitCount = 0;
    dispatcher.await();
    List<ContainerId> contsToClean;
    int cleanedConts = 0;
    do {
      contsToClean = resp.getContainersToCleanup();
      cleanedConts += contsToClean.size();
      if (cleanedConts >= 1) {
        break;
      }
      Thread.sleep(100);
      resp = nm.nodeHeartbeat(true);
      dispatcher.await();
    }
    while(waitCount++ < 200);
{code}
## Define waitCount and cleanedCounts on the same line? 
## while should be on the same line as the closing brace. 
## Remove dispatcher.await() outside the loop and have it as the first statement in the do-block?


> FairScheduler missing handling of containers for unknown application attempts 
> ------------------------------------------------------------------------------
>
>                 Key: YARN-2244
>                 URL: https://issues.apache.org/jira/browse/YARN-2244
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>            Priority: Critical
>         Attachments: YARN-2224.patch, YARN-2244.001.patch, YARN-2244.002.patch, YARN-2244.003.patch,
YARN-2244.004.patch
>
>
> We are missing changes in patch MAPREDUCE-3596 in FairScheduler. Among other fixes that
were common across schedulers, there were some scheduler specific fixes added to handle containers
for unknown application attempts. Without these fair scheduler simply logs that an unknown
container was found and continues to let it run. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message