hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2208) AMRMTokenManager need to have a way to roll over AMRMToken
Date Mon, 07 Jul 2014 23:29:33 GMT

    [ https://issues.apache.org/jira/browse/YARN-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054283#comment-14054283
] 

Jian He commented on YARN-2208:
-------------------------------


Some comments on the patch:
- RM_AMRM_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS -> RM_AM_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
- am-rm-tokens.master-key-rolling-interval-secs -> am-tokens.master-key-rolling-interval-secs
- RM_NMTOKEN ?
{code}
          YarnConfiguration.RM_NMTOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
              + " should be more than 2 X "
              + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
{code}
- Should we cache the am token password instead of re-computing password each time rpc is
invoked?
{code}
    org.apache.hadoop.security.token.Token<AMRMTokenIdentifier> token =
        rm1.getRMContext().getRMApps().get(appAttemptId.getApplicationId())
            .getRMAppAttempt(appAttemptId).getAMRMToken();
    try {
      UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
      ugi.addTokenIdentifier(token.decodeIdentifier());
    } catch (IOException e) {
      throw new YarnRuntimeException(e);
    }
{code}
- please fix the test failure also

> AMRMTokenManager need to have a way to roll over AMRMToken
> ----------------------------------------------------------
>
>                 Key: YARN-2208
>                 URL: https://issues.apache.org/jira/browse/YARN-2208
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-2208.1.patch, YARN-2208.2.patch, YARN-2208.3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message