hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2013) The diagnostics is always the ExitCodeException stack when the container crashes
Date Sun, 20 Jul 2014 04:08:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067790#comment-14067790
] 

Junping Du commented on YARN-2013:
----------------------------------

Thank you for updating the patch, [~ozawa]! Patch looks good to me overall. Some minor comments:
{code}
+        builder.append("exit code: " + exitCode + "\n");
+        builder.append(StringUtils.stringifyException(e) + "\n");
+        if (!shExec.getOutput().isEmpty()) {
+          builder.append(shExec.getOutput() + "\n");
+        }
+        ...
{code}
We should add "Exception:" or "Shell Output:", etc. before the actual message there just like
we do for container id and exit code.




> The diagnostics is always the ExitCodeException stack when the container crashes
> --------------------------------------------------------------------------------
>
>                 Key: YARN-2013
>                 URL: https://issues.apache.org/jira/browse/YARN-2013
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Zhijie Shen
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2013.1.patch, YARN-2013.2.patch, YARN-2013.3-2.patch, YARN-2013.3.patch,
YARN-2013.4.patch
>
>
> When a container crashes, ExitCodeException will be thrown from Shell. Default/LinuxContainerExecutor
captures the exception, put the exception stack into the diagnostic. Therefore, the exception
stack is always the same. 
> {code}
>         String diagnostics = "Exception from container-launch: \n"
>             + StringUtils.stringifyException(e) + "\n" + shExec.getOutput();
>         container.handle(new ContainerDiagnosticsUpdateEvent(containerId,
>             diagnostics));
> {code}
> In addition, it seems that the exception always has a empty message as there's no message
from stderr. Hence the diagnostics is not of much use for users to analyze the reason of container
crash.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message