Return-Path: 
 <yarn-issues-return-29559-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C22B5114DD
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Tue, 17 Jun 2014 02:57:01 +0000 (UTC)
Received: (qmail 47867 invoked by uid 500); 17 Jun 2014 02:57:01 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 47814 invoked by uid 500); 17 Jun 2014 02:57:01 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 47798 invoked by uid 99); 17 Jun 2014 02:57:01 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2014 02:57:01 +0000
Date: Tue, 17 Jun 2014 02:57:01 +0000 (UTC)
From: "Zhijie Shen (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12721489.1402947011321.143378.1402973821521@arcas>
In-Reply-To: <JIRA.12721489.1402947011321@arcas>
References: <JIRA.12721489.1402947011321@arcas>
Subject: [jira] [Commented] (YARN-2165) Timelineserver should validate that
 yarn.timeline-service.ttl-ms is greater than zero
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033377#comment-14033377 ] 

Zhijie Shen commented on YARN-2165:
-----------------------------------

[~karams], how about gathering the similar validation issues (YARN-2166) here?

> Timelineserver should validate that yarn.timeline-service.ttl-ms is greater than zero
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2165
>                 URL: https://issues.apache.org/jira/browse/YARN-2165
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Karam Singh
>
> Timelineserver should validate that yarn.timeline-service.ttl-ms is greater than zero
> Currently if set yarn.timeline-service.ttl-ms=0 
> Or yarn.timeline-service.ttl-ms=-86400 
> Timeline server start successfully with complaining
> {code}
> 2014-06-15 14:52:16,562 INFO  timeline.LeveldbTimelineStore (LeveldbTimelineStore.java:<init>(247)) - Starting deletion thread with ttl -604800000 and cycle interval 300000
> {code}
> At starting timelinserver should that yarn.timeline-service-ttl-ms > 0
> otherwise specially for -ive value discard oldvalues timestamp will be set future value. Which may lead to inconsistancy in behavior 
> {code}
>     public void run() {
>       while (true) {
>         long timestamp = System.currentTimeMillis() - ttl;
>         try {
>           discardOldEntities(timestamp);
>           Thread.sleep(ttlInterval);
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)