Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4383F1171B for ; Sat, 7 Jun 2014 11:20:06 +0000 (UTC) Received: (qmail 3396 invoked by uid 500); 7 Jun 2014 11:20:06 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 3364 invoked by uid 500); 7 Jun 2014 11:20:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 3353 invoked by uid 99); 7 Jun 2014 11:20:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jun 2014 11:20:06 +0000 Date: Sat, 7 Jun 2014 11:20:05 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020783#comment-14020783 ] Hudson commented on YARN-2117: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk #576 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/576/]) YARN-2117. Fixed the issue that secret file reader is potentially not closed in TimelineAuthenticationFilterInitializer. Contributed by Chen He. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1600994) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java > Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block > ----------------------------------------------------------------------------------------------------------- > > Key: YARN-2117 > URL: https://issues.apache.org/jira/browse/YARN-2117 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Ted Yu > Assignee: Chen He > Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN-2117-v2.patch, YARN-2117.patch > > > Here is related code: > {code} > Reader reader = new FileReader(signatureSecretFile); > int c = reader.read(); > while (c > -1) { > secret.append((char) c); > c = reader.read(); > } > reader.close(); > {code} > If IOException is thrown out of reader.read(), reader would be left unclosed. -- This message was sent by Atlassian JIRA (v6.2#6252)