Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 6 Jun 2014 19:46:04 +0000 (UTC)
From: "Chen He (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12717696.1401495242366.84294.1402083964908@arcas>
In-Reply-To: <JIRA.12717696.1401495242366@arcas>
References: <JIRA.12717696.1401495242366@arcas>
Subject: [jira] [Commented] (YARN-2117) Close of Reader in
 TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in
 finally block
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020283#comment-14020283 ] 

Chen He commented on YARN-2117:
-------------------------------

this patch does not need to introduce new test code.

> Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2117
>                 URL: https://issues.apache.org/jira/browse/YARN-2117
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-2117-v2.patch, YARN-2117.patch
>
>
> Here is related code:
> {code}
>         Reader reader = new FileReader(signatureSecretFile);
>         int c = reader.read();
>         while (c > -1) {
>           secret.append((char) c);
>           c = reader.read();
>         }
>         reader.close();
> {code}
> If IOException is thrown out of reader.read(), reader would be left unclosed.


--
This message was sent by Atlassian JIRA
(v6.2#6252)