Return-Path: 
 <yarn-issues-return-29467-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2D932115B9
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Sun, 15 Jun 2014 23:39:02 +0000 (UTC)
Received: (qmail 95374 invoked by uid 500); 15 Jun 2014 23:39:01 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 95322 invoked by uid 500); 15 Jun 2014 23:39:01 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 95310 invoked by uid 99); 15 Jun 2014 23:39:01 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jun 2014 23:39:01 +0000
Date: Sun, 15 Jun 2014 23:39:01 +0000 (UTC)
From: "Tsuyoshi OZAWA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12713893.1399986079908.135126.1402875541773@arcas>
In-Reply-To: <JIRA.12713893.1399986079908@arcas>
References: <JIRA.12713893.1399986079908@arcas>
Subject: [jira] [Commented] (YARN-2052) ContainerId creation after work
 preserving restart is broken
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032053#comment-14032053 ] 

Tsuyoshi OZAWA commented on YARN-2052:
--------------------------------------

[~vinodkv], thank you for the comment. I agree with fixing toString or other parts on another JIRA. 

The attached patch includes following updates:

* Updated yarn_protos.proto to include RM's id(cluster_timestamp and uuid of rm-id). RM-Id should be converted into  UUID, because RM-ID can include underscore and it can prevent users from parsing correctly.
* Added {{setClusterTimestamp}}/{{setRMUUID}} to {{ContainerId}} and implemented them in {{ContainerIdPBImpl}}.
* Updated TestFileSystemApplicationHistoryStore, because of the size of entities are changed.

[~jianhe], can you take a look?

{quote}
Therefore, I think container_XXX_000_uuid_rm1 is better format. 
{quote}

Note that this was wrong, I meant the format should be {{container_XXX_000_<timestamp>_<uuid>}}. 

> ContainerId creation after work preserving restart is broken
> ------------------------------------------------------------
>
>                 Key: YARN-2052
>                 URL: https://issues.apache.org/jira/browse/YARN-2052
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2052.1.patch
>
>
> Container ids are made unique by using the app identifier and appending a monotonically increasing sequence number to it. Since container creation is a high churn activity the RM does not store the sequence number per app. So after restart it does not know what the new sequence number should be for new allocations.



--
This message was sent by Atlassian JIRA
(v6.2#6252)