hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2155) FairScheduler: Incorrect threshold check for preemption
Date Fri, 13 Jun 2014 11:31:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030524#comment-14030524
] 

Hudson commented on YARN-2155:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #582 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/582/])
YARN-2155. FairScheduler: Incorrect threshold check for preemption. (Wei Yan via kasha) (kasha:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602295)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairSchedulerPreemption.java


> FairScheduler: Incorrect threshold check for preemption
> -------------------------------------------------------
>
>                 Key: YARN-2155
>                 URL: https://issues.apache.org/jira/browse/YARN-2155
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>             Fix For: 2.5.0
>
>         Attachments: YARN-2155.patch
>
>
> {code}
> private boolean shouldAttemptPreemption() {
>   if (preemptionEnabled) {
>     return (preemptionUtilizationThreshold < Math.max(
>         (float) rootMetrics.getAvailableMB() / clusterResource.getMemory(),
>         (float) rootMetrics.getAvailableVirtualCores() /
>             clusterResource.getVirtualCores()));
>   }
>   return false;
> }
> {code}
> preemptionUtilizationThreshould should be compared with allocatedResource instead of
availableResource.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message