hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2148) TestNMClient failed due more exit code values added and passed to AM
Date Thu, 12 Jun 2014 00:45:03 GMT

    [ https://issues.apache.org/jira/browse/YARN-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028662#comment-14028662
] 

Wangda Tan commented on YARN-2148:
----------------------------------

Sorry [~zjshen], I missed your comment,
bq. Previously, I have 0 here because it is possible that the container finishes so quickly
that kill command even hasn't be processed.
This should be a rare case, but it should be possible. In this case, the following assertion
will fail as well?
{code}
        if (status.getState() == state) {
          ....
          assertTrue("" + index + ": " + status.getDiagnostics(),
              status.getDiagnostics().contains(diagnostics));
          ...
        }
{code}

bq. And previously, the code can be 137 or 143, depending on whether the container is terminated
or killed. Haven't look into the details of YARN-2091, but please please make sure both scenarios
are covered.
What's the differences between 137 and 143?

I think we may need update TestNMClient to cover all cases. 

> TestNMClient failed due more exit code values added and passed to AM
> --------------------------------------------------------------------
>
>                 Key: YARN-2148
>                 URL: https://issues.apache.org/jira/browse/YARN-2148
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0, 2.5.0
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>             Fix For: 2.5.0
>
>         Attachments: YARN-2148.patch
>
>
> Currently, TestNMClient will be failed in trunk, see https://builds.apache.org/job/PreCommit-YARN-Build/3959/testReport/junit/org.apache.hadoop.yarn.client.api.impl/TestNMClient/testNMClient/
> {code}
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertTrue(Assert.java:52)
> 	at org.apache.hadoop.yarn.client.api.impl.TestNMClient.testGetContainerStatus(TestNMClient.java:385)
> 	at org.apache.hadoop.yarn.client.api.impl.TestNMClient.testContainerManagement(TestNMClient.java:347)
> 	at org.apache.hadoop.yarn.client.api.impl.TestNMClient.testNMClient(TestNMClient.java:226)
> {code}
> Test cases in TestNMClient uses following code to verify exit code of COMPLETED containers
> {code}
>           testGetContainerStatus(container, i, ContainerState.COMPLETE,
>               "Container killed by the ApplicationMaster.", Arrays.asList(
>                   new Integer[] {137, 143, 0}));
> {code}
> But YARN-2091 added logic to make exit code reflecting the actual status, so exit code
of the "killed by ApplicationMaster" will be -105,
> {code}
>       if (container.hasDefaultExitCode()) {
>         container.exitCode = exitEvent.getExitCode();
>       }
> {code}
> We should update test case as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message