hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2145) FairScheduler can assign more resources to queue with MaxShare set.
Date Wed, 11 Jun 2014 13:33:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027751#comment-14027751

Hadoop QA commented on YARN-2145:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3960//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3960//console

This message is automatically generated.

> FairScheduler can assign more resources to queue with MaxShare set.
> -------------------------------------------------------------------
>                 Key: YARN-2145
>                 URL: https://issues.apache.org/jira/browse/YARN-2145
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.5.0
>            Reporter: Andrey Stepachev
>         Attachments: YARN-2145.diff
> method fair.FSQueue#assignContainerPreCheck() uses Resources.fitsIn incorrectly, because
if queue is at its maximum capacity method returns true and container can be assigned to queue
with maximum resources already consumed.
> That is because fitsIn code do '<=' comparison and if allocated resources == max resources
fitsIn still returns true, and consequently pre check successes
> {code}
>   public static boolean fitsIn(Resource smaller, Resource bigger) {
>     return smaller.getMemory() <= bigger.getMemory() &&
>         smaller.getVirtualCores() <= bigger.getVirtualCores();
>   }
> {code}
> Provided patch introduced Resources.less method, it more lightweight then lessThan. 

This message was sent by Atlassian JIRA

View raw message