hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2143) Merge common killContainer logic of Fair/Capacity scheduler into AbstractYarnScheduler
Date Tue, 24 Jun 2014 09:48:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041924#comment-14041924
] 

Sunil G commented on YARN-2143:
-------------------------------

Hi [~gp.leftnoteasy]

*FairScheduler#warnOrKillContainer* and *CapacityScheduler#killContainer* mainly has only
one common part. Both will invoke its own completedContainer with KILL event.
After doing more code review, I feel that we may not be able to merge these two methods as
a single one in AbstractYarnScheduler. But this new api in AbstractYarnScheduler can be invoked
from both these methods (warnOrKillContainer and killContainer) to perform adding ResourceRequest
back to Scheduler purpose.

If this is fine, may be we can use this JIRA only to add a new method named *killPreemptedContainer*
for AbstractYarnScheduler and this will be called from warnOrKillContainer and killContainer.
Please share your thoughts [~leftnoteasy] and [~vinodkv]

> Merge common killContainer logic of Fair/Capacity scheduler into AbstractYarnScheduler
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2143
>                 URL: https://issues.apache.org/jira/browse/YARN-2143
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>
> Currently, CapacityScheduler has killContainer API inherited from PreemptableResourceScheduler,
and FairScheduler uses warnOrKillContainer to do container preemption. We'd better to merge
common code to kill container into AbstractYarnScheduler.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message