hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()
Date Fri, 06 Jun 2014 20:17:03 GMT

    [ https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020310#comment-14020310
] 

Tsuyoshi OZAWA commented on YARN-2122:
--------------------------------------

[~rkanter], thank you for updating a patch! Minor nits comments from me:

Should we call {{super.serviceInit(conf)}} at the end of this method instead of at the start
of this method?

{code}
+    super.serviceInit(conf);
+    if (allocFile != null) {
+      reloadThread = new Thread() {
{code}

Otherwise code looks good to me.

> In AllocationFileLoaderService, the reloadThread should be created in init() and started
in start()
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2122
>                 URL: https://issues.apache.org/jira/browse/YARN-2122
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.4.0
>            Reporter: Karthik Kambatla
>            Assignee: Robert Kanter
>         Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch
>
>
> AllcoationFileLoaderService has this reloadThread that is currently created and started
in start(). Instead, it should be created in init() and started in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message