hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
Date Fri, 06 Jun 2014 16:58:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020038#comment-14020038
] 

Zhijie Shen commented on YARN-2117:
-----------------------------------

[~airbots], thanks for the patch! Here're some comments:

1. Indent is breaking.
{code}
-        throw new RuntimeException(
-            "Could not read HTTP signature secret file: "
+          throw new RuntimeException(
+              "Could not read HTTP signature secret file: "
+                  + signatureSecretFile)
{code}

2. You can use IOUtils to cleanup the closable objects.

> Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed
in finally block
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2117
>                 URL: https://issues.apache.org/jira/browse/YARN-2117
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-2117.patch
>
>
> Here is related code:
> {code}
>         Reader reader = new FileReader(signatureSecretFile);
>         int c = reader.read();
>         while (c > -1) {
>           secret.append((char) c);
>           c = reader.read();
>         }
>         reader.close();
> {code}
> If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message