hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
Date Mon, 02 Jun 2014 14:36:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015429#comment-14015429
] 

Hadoop QA commented on YARN-2117:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12647900/YARN-2117.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3885//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3885//console

This message is automatically generated.

> Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed
in finally block
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2117
>                 URL: https://issues.apache.org/jira/browse/YARN-2117
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-2117.patch
>
>
> Here is related code:
> {code}
>         Reader reader = new FileReader(signatureSecretFile);
>         int c = reader.read();
>         while (c > -1) {
>           secret.append((char) c);
>           c = reader.read();
>         }
>         reader.close();
> {code}
> If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message