hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2091) Add ContainerExitStatus.KILL_EXCEEDED_MEMORY and pass it to app masters
Date Fri, 06 Jun 2014 20:51:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020350#comment-14020350
] 

Bikas Saha commented on YARN-2091:
----------------------------------

How about naming it hasDefaultExitCode() and directly using ContainerExitStatus.INVALID instead
of creating a new member variable.
{code}+
+  private boolean isDefaultExitCode() {
+    return (this.exitCode == DEFAULT_EXIT_CODE);
+  }{code}

Can we rename this to getContainerExitStatus() so that its clear that we are getting a ContainerExitStatus
value.
{code}+  public int getReason() {
+    return this.reason;
+  }{code}

I would suggest the following names
KILL_AM_STOP_CONTAINER -> KILLED_BY_APPMASTER - Container was terminated by stop request
by the app master
KILL_BY_RESOURCEMANAGER -> KILLED_BY_RESOURCEMANAGER - Container was terminated by the
resource manager.
KILL_FINISHED_APPMASTER -> KILLED_AFTER_APP_COMPLETION - Container was terminated after
the application finished
KILL_EXCEEDED_PMEM -> KILLED_EXCEEDED_PMEM - Container terminated because of exceeding
allocated physical memory
KILL_EXCEEDED_VMEM -> KILLED_EXCEEDED_VMEM - Container terminated because of exceeding
allocated virtual memory

Spurious edit?
{code}-      //if the current state is NEW it means the CONTAINER_INIT was never 
+      //if the current state is NEW it means the CONTAINER_INIT was never{code}

I am +1 after these comments. [~vinodkv] Do you have any further comments?


> Add ContainerExitStatus.KILL_EXCEEDED_MEMORY and pass it to app masters
> -----------------------------------------------------------------------
>
>                 Key: YARN-2091
>                 URL: https://issues.apache.org/jira/browse/YARN-2091
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-2091.1.patch, YARN-2091.2.patch, YARN-2091.3.patch, YARN-2091.4.patch,
YARN-2091.5.patch, YARN-2091.6.patch, YARN-2091.7.patch
>
>
> Currently, the AM cannot programmatically determine if the task was killed due to using
excessive memory. The NM kills it without passing this information in the container status
back to the RM. So the AM cannot take any action here. The jira tracks adding this exit status
and passing it from the NM to the RM and then the AM. In general, there may be other such
actions taken by YARN that are currently opaque to the AM. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message