hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1480) RM web services getApps() accepts many more filters than ApplicationCLI "list" command
Date Tue, 17 Jun 2014 07:05:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033502#comment-14033502
] 

Zhijie Shen commented on YARN-1480:
-----------------------------------

Hi [~kj-ki], thanks for the patch. Here're some meta comments on it:

1. I looked into the current RMWebServices#getApps(), and below is the list of missing options
in ApplicationCLI. "queue" (current "queue" option is for the "movetoqueue" command) and "tags"
are not covered in the patch. If it's not a big addition, is it better to include these two
options into the option list?
{code}
      @QueryParam("finalStatus") String finalStatusQuery,
      @QueryParam("user") String userQuery,
      @QueryParam("queue") String queueQuery,
      @QueryParam("limit") String count,
      @QueryParam("startedTimeBegin") String startedBegin,
      @QueryParam("startedTimeEnd") String startedEnd,
      @QueryParam("finishedTimeBegin") String finishBegin,
      @QueryParam("finishedTimeEnd") String finishEnd,
      @QueryParam("applicationTags") Set<String> applicationTags
{code}

2. ApplicationClientProtocol#getApplications already support full filters, while YarnClient
seems not to support the full options now. IMHO, the right way here  is to make YarnClient
to support full filters, and ApplicationCLI simply calls the API. It is an inefficient way
to pull a long app list from RM and do local filtering.

> RM web services getApps() accepts many more filters than ApplicationCLI "list" command
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-1480
>                 URL: https://issues.apache.org/jira/browse/YARN-1480
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Kenji Kikushima
>         Attachments: YARN-1480-2.patch, YARN-1480-3.patch, YARN-1480-4.patch, YARN-1480-5.patch,
YARN-1480.patch
>
>
> Nowadays RM web services getApps() accepts many more filters than ApplicationCLI "list"
command, which only accepts "state" and "type". IMHO, ideally, different interfaces should
provide consistent functionality. Is it better to allow more filters in ApplicationCLI?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message