hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1424) RMAppAttemptImpl should precompute a zeroed ApplicationResourceUsageReport to return when attempt not active
Date Wed, 04 Jun 2014 22:43:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018298#comment-14018298
] 

Hadoop QA commented on YARN-1424:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12645270/YARN1424-01.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3910//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3910//console

This message is automatically generated.

> RMAppAttemptImpl should precompute a zeroed ApplicationResourceUsageReport to return
when attempt not active
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1424
>                 URL: https://issues.apache.org/jira/browse/YARN-1424
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Sandy Ryza
>            Assignee: Ray Chiang
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN1424-01.patch
>
>
> RMAppImpl has a DUMMY_APPLICATION_RESOURCE_USAGE_REPORT to return when the caller of
createAndGetApplicationReport doesn't have access.
> RMAppAttemptImpl should have something similar for getApplicationResourceUsageReport.
> It also might make sense to put the dummy report into ApplicationResourceUsageReport
and allow both to use it.
> A test would also be useful to verify that RMAppAttemptImpl#getApplicationResourceUsageReport
doesn't return null if the scheduler doesn't have a report to return.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message