hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1366) AM should implement Resync with the ApplicationMasterService instead of shutting down
Date Mon, 30 Jun 2014 04:41:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047366#comment-14047366
] 

Jian He commented on YARN-1366:
-------------------------------

Thanks for working on the patch ! some comments:
- isApplicationMasterRegistered is actually not an argument, may be throw ApplicationMasterNotRegsiteredException
in this case ?
{code}
Preconditions.checkArgument(isApplicationMasterRegistered,
        "Application Master is trying to unregister before registering.");
{code}
- pom.xml format: use spaces instead of tabs
{code}
+    <dependency>
+  		<groupId>org.apache.hadoop</groupId>
+  		<artifactId>hadoop-yarn-common</artifactId>
+  		<type>test-jar</type>
+  		<scope>test</scope>
+  	</dependency>
{code}
-  testAMRMClientResendsRequestsOnRMRestart seems not testing re-sending pendingReleases across
RM restart, because the pending releases seems already decremented to zero before restart
happens.
- Not related to this jira. Current ApplicationMasterService does not allow multiple registers.
Application may want to update its tracking url etc.  Should we make AMS accept multiple registers
 ? 
{code} Preconditions.checkArgument(!isApplicationMasterRegistered,
        "ApplicationMaster is already registered");
{code}

> AM should implement Resync with the ApplicationMasterService instead of shutting down
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-1366
>                 URL: https://issues.apache.org/jira/browse/YARN-1366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Rohith
>         Attachments: YARN-1366.1.patch, YARN-1366.2.patch, YARN-1366.3.patch, YARN-1366.4.patch,
YARN-1366.5.patch, YARN-1366.6.patch, YARN-1366.7.patch, YARN-1366.patch, YARN-1366.prototype.patch,
YARN-1366.prototype.patch
>
>
> The ApplicationMasterService currently sends a resync response to which the AM responds
by shutting down. The AM behavior is expected to change to calling resyncing with the RM.
Resync means resetting the allocate RPC sequence number to 0 and the AM should send its entire
outstanding request to the RM. Note that if the AM is making its first allocate call to the
RM then things should proceed like normal without needing a resync. The RM will return all
containers that have completed since the RM last synced with the AM. Some container completions
may be reported more than once.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message