hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1365) ApplicationMasterService to allow Register and Unregister of an app that was running before restart
Date Fri, 20 Jun 2014 19:21:24 GMT

    [ https://issues.apache.org/jira/browse/YARN-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039222#comment-14039222
] 

Jian He commented on YARN-1365:
-------------------------------

looks good overall, just some minor comments:
This is audit logger removed. I think we should have it back and adjust it for resync,  given
finishApplicationMaster call also retains it.
{code}
-        RMAuditLogger.logFailure(
-            this.rmContext.getRMApps().get(appAttemptId.getApplicationId())
-                .getUser(), AuditConstants.REGISTER_AM, "",
-            "ApplicationMasterService", message,
-            appAttemptId.getApplicationId(),
-            appAttemptId);
{code}

Found code comment “org.apache.hadoop.yarn.api.protocolrecords.RegisterApplicationMasterRequest”
in the ApplicationMasterNotRegisteredException is too long and unreadable.. can you change
it to use RegisterApplicationMasterRequest instead? thx
testRMRestartWorkPreservingAppReregister-> testAppReregisterOnRMWorkPreservingRestart

> ApplicationMasterService to allow Register and Unregister of an app that was running
before restart
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1365
>                 URL: https://issues.apache.org/jira/browse/YARN-1365
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-1365.001.patch, YARN-1365.002.patch, YARN-1365.003.patch, YARN-1365.004.patch,
YARN-1365.005.patch, YARN-1365.005.patch, YARN-1365.006.patch, YARN-1365.007.patch, YARN-1365.initial.patch
>
>
> For an application that was running before restart, the ApplicationMasterService currently
throws an exception when the app tries to make the initial register or final unregister call.
These should succeed and the RMApp state machine should transition to completed like normal.
Unregistration should succeed for an app that the RM considers complete since the RM may have
died after saving completion in the store but before notifying the AM that the AM is free
to exit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message