Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 30 May 2014 05:19:01 +0000 (UTC)
From: "Binglin Chang (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12716581.1401086176157.45083.1401427141845@arcas>
In-Reply-To: <JIRA.12716581.1401086176157@arcas>
References: <JIRA.12716581.1401086176157@arcas>
Subject: [jira] [Updated] (YARN-2103) Inconsistency between viaProto flag
 and initial value of SerializedExceptionProto.Builder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/YARN-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Binglin Chang updated YARN-2103:
--------------------------------

    Attachment: YARN-2103.v1.patch

Thanks for the review [~djp], update patch addressing your comments.

> Inconsistency between viaProto flag and initial value of SerializedExceptionProto.Builder
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-2103
>                 URL: https://issues.apache.org/jira/browse/YARN-2103
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: YARN-2103.v1.patch, YARN-2103.v2.patch
>
>
> Bug 1:
> {code}
>   SerializedExceptionProto proto = SerializedExceptionProto
>       .getDefaultInstance();
>   SerializedExceptionProto.Builder builder = null;
>   boolean viaProto = false;
> {code}
> Since viaProto is false, we should initiate build rather than proto
> Bug 2:
> the class does not provide hashcode() and equals() like other PBImpl records, this class is used in other records, it may affect other records' behavior. 


--
This message was sent by Atlassian JIRA
(v6.2#6252)