Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 29 May 2014 17:31:02 +0000 (UTC)
From: "Junping Du (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12716581.1401086176157.40413.1401384662732@arcas>
In-Reply-To: <JIRA.12716581.1401086176157@arcas>
References: <JIRA.12716581.1401086176157@arcas>
Subject: [jira] [Commented] (YARN-2103) Inconsistency between viaProto flag
 and initial value of SerializedExceptionProto.Builder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012572#comment-14012572 ] 

Junping Du commented on YARN-2103:
----------------------------------

Thanks [~decster] for the patch and [~ozawa] for review.
bq. How about adding concrete tests as a first step of generic tests on YARN-2051? What do you think, Junping Du?
That sounds good to me. We should add some concrete tests for some highly suspected PBImpls as the first step and refactor to/add more generic tests later. In this case, the original constructor (the one without parameter) is wrong as the object created with viaProto=false and builder to be null at the same time. We should add a unit test here. 

On code format, please try to follow our code convention in hadoop wiki - Sun/Oracle java programming convention (only difference is using 2 indentations instead of 4). In this convention, we have:
{code}
Note: if statements always use braces {}. Avoid the following error-prone form:
if (condition) //AVOID! THIS OMITS THE BRACES {}!
statement;
{code}
So may be we should try to be right for all new added code instead of staying the same with legacy code?

> Inconsistency between viaProto flag and initial value of SerializedExceptionProto.Builder
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-2103
>                 URL: https://issues.apache.org/jira/browse/YARN-2103
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: YARN-2103.v1.patch
>
>
> Bug 1:
> {code}
>   SerializedExceptionProto proto = SerializedExceptionProto
>       .getDefaultInstance();
>   SerializedExceptionProto.Builder builder = null;
>   boolean viaProto = false;
> {code}
> Since viaProto is false, we should initiate build rather than proto
> Bug 2:
> the class does not provide hashcode() and equals() like other PBImpl records, this class is used in other records, it may affect other records' behavior. 


--
This message was sent by Atlassian JIRA
(v6.2#6252)