Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 23 May 2014 17:01:05 +0000 (UTC)
From: "Tsuyoshi OZAWA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12716270.1400827134781.9471.1400864465009@arcas>
In-Reply-To: <JIRA.12716270.1400827134781@arcas>
References: <JIRA.12716270.1400827134781@arcas>
Subject: [jira] [Commented] (YARN-2096) Race in
 TestRMRestart#testQueueMetricsOnRMRestart
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007363#comment-14007363 ] 

Tsuyoshi OZAWA commented on YARN-2096:
--------------------------------------

The change looks good to me too(non-binding).

> Race in TestRMRestart#testQueueMetricsOnRMRestart
> -------------------------------------------------
>
>                 Key: YARN-2096
>                 URL: https://issues.apache.org/jira/browse/YARN-2096
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2096.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testQueueMetricsOnRMRestart fails randomly because of a race condition.
> The test validates that metrics are incremented, but does not wait for all transitions to finish before checking for the values.
> It also resets metrics after kicking off recovery of second RM. The metrics that need to be incremented race with this reset causing test to fail randomly.
> We need to wait for the right transitions.


--
This message was sent by Atlassian JIRA
(v6.2#6252)