Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 13 May 2014 15:23:17 +0000 (UTC)
From: "Tsuyoshi OZAWA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12712070.1399073026290.337940.1399994597279@arcas>
In-Reply-To: <JIRA.12712070.1399073026290@arcas>
References: <JIRA.12712070.1399073026290@arcas>
Subject: [jira] [Commented] (YARN-2017) Merge some of the common lib code in
 schedulers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996492#comment-13996492 ] 

Tsuyoshi OZAWA commented on YARN-2017:
--------------------------------------

Thanks for your patch, Jian! Some comments:

1. +1 for using Generics to avoid warnings by casting as Sandy and Wangda mentioned.
2. Can we assert node with Preconditions.checkNotNull() in SchedulerNode?
{code}
  public SchedulerNode(RMNode node, boolean usePortForNodeName) {
    this.rmNode = node;
    this.availableResource = Resources.clone(node.getTotalCapability());
    this.totalResourceCapability = Resources.clone(node.getTotalCapability());
    ...
  }
{code}
3. Some lines over 80 chars per line. 

> Merge some of the common lib code in schedulers
> -----------------------------------------------
>
>                 Key: YARN-2017
>                 URL: https://issues.apache.org/jira/browse/YARN-2017
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2017.1.patch
>
>
> A bunch of same code is repeated among schedulers, e.g:  between FicaSchedulerNode and FSSchedulerNode. It's good to merge and share them in a common base.


--
This message was sent by Atlassian JIRA
(v6.2#6252)