Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B67E0113E6 for ; Tue, 13 May 2014 06:00:08 +0000 (UTC) Received: (qmail 29911 invoked by uid 500); 10 May 2014 22:15:00 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 29479 invoked by uid 500); 10 May 2014 22:14:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 28496 invoked by uid 99); 10 May 2014 22:14:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 22:14:53 +0000 Date: Sat, 10 May 2014 22:14:53 +0000 (UTC) From: "Junping Du (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2011) Typo in TestLeafQueue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993395#comment-13993395 ] Junping Du commented on YARN-2011: ---------------------------------- Nice catch, [~airbots]! There is also a warning that following code in testAppAttemptMetrics() is never used: {code} FiCaSchedulerApp app_0 = new FiCaSchedulerApp(appAttemptId_0, user_0, a, null, rmContext); {code} Given you already there, would you like to fix this warning in your patch as well? I will review and commit it. Thanks! > Typo in TestLeafQueue > --------------------- > > Key: YARN-2011 > URL: https://issues.apache.org/jira/browse/YARN-2011 > Project: Hadoop YARN > Issue Type: Test > Affects Versions: 2.4.0 > Reporter: Chen He > Assignee: Chen He > Priority: Trivial > Attachments: YARN-2011.patch > > > a.assignContainers(clusterResource, node_0); > assertEquals(2*GB, a.getUsedResources().getMemory()); > assertEquals(2*GB, app_0.getCurrentConsumption().getMemory()); > assertEquals(0*GB, app_1.getCurrentConsumption().getMemory()); > assertEquals(0*GB, app_0.getHeadroom().getMemory()); // User limit = 2G > assertEquals(0*GB, app_0.getHeadroom().getMemory()); // User limit = 2G > // Again one to user_0 since he hasn't exceeded user limit yet > a.assignContainers(clusterResource, node_0); > assertEquals(3*GB, a.getUsedResources().getMemory()); > assertEquals(2*GB, app_0.getCurrentConsumption().getMemory()); > assertEquals(1*GB, app_1.getCurrentConsumption().getMemory()); > assertEquals(0*GB, app_0.getHeadroom().getMemory()); // 3G - 2G > assertEquals(0*GB, app_0.getHeadroom().getMemory()); // 3G - 2G -- This message was sent by Atlassian JIRA (v6.2#6252)