Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E507911756 for ; Tue, 20 May 2014 21:58:38 +0000 (UTC) Received: (qmail 57224 invoked by uid 500); 20 May 2014 21:58:38 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 57178 invoked by uid 500); 20 May 2014 21:58:38 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 57170 invoked by uid 99); 20 May 2014 21:58:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 May 2014 21:58:38 +0000 Date: Tue, 20 May 2014 21:58:38 +0000 (UTC) From: "Vinod Kumar Vavilapalli (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1569) For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, SchedulerEvent should get checked (instanceof) for appropriate type before casting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004034#comment-14004034 ] Vinod Kumar Vavilapalli commented on YARN-1569: ----------------------------------------------- Let's not do this. If we are getting wrong events that are incorrectly getting routed, I'd rather catch them at compile time instead of putting out a log that nobody will look at. I propose we close this as WONT FIX. > For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, SchedulerEvent should get checked (instanceof) for appropriate type before casting > ----------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: YARN-1569 > URL: https://issues.apache.org/jira/browse/YARN-1569 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler > Reporter: Junping Du > Assignee: zhihai xu > Priority: Minor > Labels: newbie > Attachments: yarn-1569.patch > > > As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should always check appropriate type before casting. > handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so far (no bug there now) but should be improved as FairScheduler. -- This message was sent by Atlassian JIRA (v6.2#6252)