hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Curino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2020) observeOnly should be checked before any preemption computation started inside containerBasedPreemptOrKill() of ProportionalCapacityPreemptionPolicy.java
Date Tue, 06 May 2014 02:10:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990203#comment-13990203
] 

Carlo Curino commented on YARN-2020:
------------------------------------

I might be missing your point, but it seems to me that  observeOnly is used to compute the
idea allocation, and log it without affecting the actual scheduler allocation... 
This is useful for debugging, and for operators to gain insight of what would happens if they
turn on preemption in their cluster, before actually doing so. 

By anticipating the observeOnly check as you propose you prevent the computation and log to
happen, which you are right will save some computation, but also 
makes it pointless to do the invocation altogether.  The effect you desire can be obtained
by turning off the preemption policy altogether.  

Is there anything else I am missing?

> observeOnly should be checked before any preemption computation started inside containerBasedPreemptOrKill()
of ProportionalCapacityPreemptionPolicy.java
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2020
>                 URL: https://issues.apache.org/jira/browse/YARN-2020
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>         Environment: all
>            Reporter: yeqi
>            Priority: Trivial
>             Fix For: 2.5.0
>
>         Attachments: YARN-2020.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> observeOnly should be checked in the very beginning of  ProportionalCapacityPreemptionPolicy.containerBasedPreemptOrKill(),
 so that to avoid unnecessary workload.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message