hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2017) Merge some of the common lib code in schedulers
Date Tue, 13 May 2014 19:00:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996776#comment-13996776
] 

Jian He commented on YARN-2017:
-------------------------------

bq. Since this is original logic of SchedulerNode, I think it's better to throw exception
instead of print a irresponsible log here. Null object passed in should be considered big
problem in scheduler. And several following places in this class.
On a second thought, user might pass in a resource request with null capability. I would prefer
not changing it. In fact, we can add many other null checks in many places. Changed the patch
back.

> Merge some of the common lib code in schedulers
> -----------------------------------------------
>
>                 Key: YARN-2017
>                 URL: https://issues.apache.org/jira/browse/YARN-2017
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2017.1.patch, YARN-2017.2.patch, YARN-2017.3.patch
>
>
> A bunch of same code is repeated among schedulers, e.g:  between FicaSchedulerNode and
FSSchedulerNode. It's good to merge and share them in a common base.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message