hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1474) Make schedulers services
Date Wed, 28 May 2014 03:47:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010728#comment-14010728
] 

Karthik Kambatla commented on YARN-1474:
----------------------------------------

Thanks Tsuyoshi. We are very close to getting this in. Few minor comments:
# In each of the schedulers, I don't think we need the following snippet or for that matter
the variable {{initialized}} at all. {{reinitialize()}} would have just the contents of else-block.
When using the scheduler, one should setRMContext(), init() and then reinitialize() thereafter.
{code}
    if (!initialized) {
      this.rmContext = rmContext;
      initScheduler(configuration);
      startSchedulerThreads();
    } else {
{code}
# ResourceSchedulerWrapper should override serviceInit, serviceStart and serviceStop methods.
Not init, start and stop. 
# I have a feeling we ll have to update some tests including the ones that are modified in
the latest patch to call scheduler.init() right after scheduler.setRMContext, if we are not
using the scheduler from a MockRM or ResourceManager instance.

> Make schedulers services
> ------------------------
>
>                 Key: YARN-1474
>                 URL: https://issues.apache.org/jira/browse/YARN-1474
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: 2.3.0, 2.4.0
>            Reporter: Sandy Ryza
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-1474.1.patch, YARN-1474.10.patch, YARN-1474.11.patch, YARN-1474.12.patch,
YARN-1474.13.patch, YARN-1474.14.patch, YARN-1474.15.patch, YARN-1474.16.patch, YARN-1474.17.patch,
YARN-1474.2.patch, YARN-1474.3.patch, YARN-1474.4.patch, YARN-1474.5.patch, YARN-1474.6.patch,
YARN-1474.7.patch, YARN-1474.8.patch, YARN-1474.9.patch
>
>
> Schedulers currently have a reinitialize but no start and stop.  Fitting them into the
YARN service model would make things more coherent.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message