hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1368) Common work to re-populate containers’ state into scheduler
Date Thu, 29 May 2014 19:57:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012795#comment-14012795

Vinod Kumar Vavilapalli commented on YARN-1368:

bq. Unless I'm missing something, Anubhav was working on this JIRA. It is great that Jian
did the refactoring to have common code for the schedulers and some testcases for it, but
most of the work has been done by Anubhav and he was working actively on it. We should reassign
the JIRA back to Anubhav and let him drive it to completion, agree?
[~tucu00], if you see the history of this ticket, there was nothing here that showed that
Anubhav was working on this. There was a prototype patch on the umbrella JIRA, but the part
of the patch that focuses on this JIRA was completely off the mark. It is specifically for
these reasons that I publicly discouraged posting prototype patch for this well-defined feature.
In this case, the prototype was off the mark, and folks(not just [~jianhe]) were confused
about the individual tasks filed.

bq. Jian He, I understand the patch is taking a different approach, which is based on the
work Anubhav started. Instead hijacking the JIRA, the correct way should have been proposing
to the assignee/author of the original patch the changes and offering to contribute/breakdown
tasks. Please do so next time.
[~tucu00], I just looked the prototype as well as this patch. Not only is this patch taking
a different approach, it is also *not* based on the work in the prototype. The approach in
the prototype is pretty broken - everyone's free to look back on both the patches and argue
about this - this one aims at correcting it by starting from scratch and moving beyond to
set the right stage for the entire effort.

Even if it were, it is sometimes a major burden to correct original patches, specifically
when their approaches are completely botched, and then direct them towards the right approach.
This one's one of those.

I agree in general that he shouldn't have re-purposed this JIRA. This JIRA's original purpose
was a very small subset of what it is doing now.

> Common work to re-populate containers’ state into scheduler
> -----------------------------------------------------------
>                 Key: YARN-1368
>                 URL: https://issues.apache.org/jira/browse/YARN-1368
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-1368.1.patch, YARN-1368.2.patch, YARN-1368.3.patch, YARN-1368.4.patch,
YARN-1368.5.patch, YARN-1368.combined.001.patch, YARN-1368.preliminary.patch
> YARN-1367 adds support for the NM to tell the RM about all currently running containers
upon registration. The RM needs to send this information to the schedulers along with the
NODE_ADDED_EVENT so that the schedulers can recover the current allocation state of the cluster.

This message was sent by Atlassian JIRA

View raw message