Return-Path: 
 <yarn-issues-return-27018-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C4F9EFFF0
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Mon, 28 Apr 2014 18:42:28 +0000 (UTC)
Received: (qmail 96860 invoked by uid 500); 28 Apr 2014 18:42:22 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 96720 invoked by uid 500); 28 Apr 2014 18:42:18 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 96651 invoked by uid 99); 28 Apr 2014 18:42:16 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 18:42:16 +0000
Date: Mon, 28 Apr 2014 18:42:16 +0000 (UTC)
From: "Jian He (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12704098.1395953289818.193216.1398710536931@arcas>
In-Reply-To: <JIRA.12704098.1395953289818@arcas>
References: <JIRA.12704098.1395953289818@arcas>
Subject: [jira] [Commented] (YARN-1885) yarn logs command does not provide
 the application logs for some applications
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-1885?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13983=
378#comment-13983378 ]=20

Jian He commented on YARN-1885:
-------------------------------

Thanks for the patch, Wangda !
Some comments.
- runningApplication -> runningApplications
{code}
RegisterNodeManagerRequest newInstance(NodeId nodeId,
      int httpPort, Resource resource, String nodeManagerVersionId,
      List<ContainerStatus> containerStatuses, List<ApplicationId> runningA=
pplication) {
{code}
similarly to =E2=80=9C public abstract void setRunningApplications(List<App=
licationId> apps);=E2=80=9D
- Put some comments about the usage of the running applications sent across=
, as this should a special case and only needed for RM restart.
- There are two routes to notify the finished apps one from the app and one=
 from the register Call. It=E2=80=99s good to have a single source of notif=
ication to cover all possible race conditions. we may send an event to the =
app and let app make decision to notify the node to cleanup the application=
s or not. Today RMAppAttempt is capturing all the ranNodes, probably we nee=
d to move that to the RMApp also.

- test cases, it=E2=80=99s better to have some integeration test, we need t=
o cover two scenarios
  -- the app is not yet finished, nm registers with the running app, eventu=
ally, nm will get the finished signal via heartbeat when app finishes.
  -- the app is already finished, nm registers with the running app, nm sho=
uld also be able to get the finished signal
  we can use MockRM to submit a app and make MockNM register with the runni=
ng app to test different scenarios.=20


> yarn logs command does not provide the application logs for some applicat=
ions
> -------------------------------------------------------------------------=
----
>
>                 Key: YARN-1885
>                 URL: https://issues.apache.org/jira/browse/YARN-1885
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Arpit Gupta
>            Assignee: Wangda Tan
>         Attachments: YARN-1885.patch, YARN-1885.patch
>
>
> During our HA testing we have seen cases where yarn application logs are =
not available through the cli but i can look at AM logs through the UI. RM =
was also being restarted in the background as the application was running.



--
This message was sent by Atlassian JIRA
(v6.2#6252)