hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1931) Private API change in YARN-1824 in 2.4 broke compatibility with previous releases
Date Sat, 12 Apr 2014 01:15:17 GMT

    [ https://issues.apache.org/jira/browse/YARN-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967322#comment-13967322
] 

Sandy Ryza commented on YARN-1931:
----------------------------------

bq. Please don't do this. Two wrongs make a right. These are private APIs. Just like Records
any many other things that MR is still using directly. We should fix MR to not depend on those,
not make methods public which are never intended to be public.
If MR shouldn't be using these APIs, I'm happy work on moving it off of them. However, these
APIs provide functionality that nearly all frameworks built on YARN need.  YARN doesn't use
them internally.  Why not expose them publicly?

bq. The class itself is marked private. So it won't appear in javadoc.
Right, this is why I'm suggesting marking it Public (of course only if we determine that it's
reasonable for apps to take advantage of it).

> Private API change in YARN-1824 in 2.4 broke compatibility with previous releases
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-1931
>                 URL: https://issues.apache.org/jira/browse/YARN-1931
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>    Affects Versions: 2.4.0
>            Reporter: Thomas Graves
>            Assignee: Sandy Ryza
>            Priority: Blocker
>         Attachments: YARN-1931-1.patch, YARN-1931.patch
>
>
> YARN-1824 broke compatibility with previous 2.x releases by changes the API's in org.apache.hadoop.yarn.util.Apps.{setEnvFromInputString,addToEnvironment}
 The old api should be added back in.
> This affects any ApplicationMasters who were using this api.  It also breaks previously
built MapReduce libraries from working with the new Yarn release as MR uses this api. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message