hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1906) TestRMRestart#testQueueMetricsOnRMRestart fails intermittently on trunk and branch2
Date Thu, 10 Apr 2014 16:04:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965492#comment-13965492
] 

Zhijie Shen commented on YARN-1906:
-----------------------------------

1. I looked into exception again:
{code}
at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testQueueMetricsOnRMRestart(TestRMRestart.java:1706)
{code}
It seems the test fails at
{code}
    // finish the AMs
    finishApplicationMaster(loadedApp1, rm2, nm1, am1);
    assertQueueMetrics(qm2, 1, 0, 0, 1);
{code}
Race condition here? Should we waitForState here before assertion?

2. One suggestion on assertQueueMetrics: It would be better to add the messages for the for
assertion sentences, such that when an exception happens, we can easily see which metric is
wrong.

> TestRMRestart#testQueueMetricsOnRMRestart fails intermittently on trunk and branch2
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-1906
>                 URL: https://issues.apache.org/jira/browse/YARN-1906
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>             Fix For: 3.0.0, 2.5.0
>
>         Attachments: YARN-1906.patch, YARN-1906.patch
>
>
> Here is the output of the format
> {noformat}
> testQueueMetricsOnRMRestart(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart)
 Time elapsed: 9.757 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<1>
> 	at org.junit.Assert.fail(Assert.java:93)
> 	at org.junit.Assert.failNotEquals(Assert.java:647)
> 	at org.junit.Assert.assertEquals(Assert.java:128)
> 	at org.junit.Assert.assertEquals(Assert.java:472)
> 	at org.junit.Assert.assertEquals(Assert.java:456)
> 	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.assertQueueMetrics(TestRMRestart.java:1735)
> 	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testQueueMetricsOnRMRestart(TestRMRestart.java:1706)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message