hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1885) yarn logs command does not provide the application logs for some applications
Date Mon, 28 Apr 2014 18:42:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983378#comment-13983378
] 

Jian He commented on YARN-1885:
-------------------------------

Thanks for the patch, Wangda !
Some comments.
- runningApplication -> runningApplications
{code}
RegisterNodeManagerRequest newInstance(NodeId nodeId,
      int httpPort, Resource resource, String nodeManagerVersionId,
      List<ContainerStatus> containerStatuses, List<ApplicationId> runningApplication)
{
{code}
similarly to “ public abstract void setRunningApplications(List<ApplicationId> apps);”
- Put some comments about the usage of the running applications sent across, as this should
a special case and only needed for RM restart.
- There are two routes to notify the finished apps one from the app and one from the register
Call. It’s good to have a single source of notification to cover all possible race conditions.
we may send an event to the app and let app make decision to notify the node to cleanup the
applications or not. Today RMAppAttempt is capturing all the ranNodes, probably we need to
move that to the RMApp also.

- test cases, it’s better to have some integeration test, we need to cover two scenarios
  -- the app is not yet finished, nm registers with the running app, eventually, nm will get
the finished signal via heartbeat when app finishes.
  -- the app is already finished, nm registers with the running app, nm should also be able
to get the finished signal
  we can use MockRM to submit a app and make MockNM register with the running app to test
different scenarios. 


> yarn logs command does not provide the application logs for some applications
> -----------------------------------------------------------------------------
>
>                 Key: YARN-1885
>                 URL: https://issues.apache.org/jira/browse/YARN-1885
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Arpit Gupta
>            Assignee: Wangda Tan
>         Attachments: YARN-1885.patch, YARN-1885.patch
>
>
> During our HA testing we have seen cases where yarn application logs are not available
through the cli but i can look at AM logs through the UI. RM was also being restarted in the
background as the application was running.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message