Return-Path: 
 <yarn-issues-return-24584-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9E57010DA0
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Thu, 13 Mar 2014 18:46:01 +0000 (UTC)
Received: (qmail 68577 invoked by uid 500); 13 Mar 2014 18:45:47 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 67882 invoked by uid 500); 13 Mar 2014 18:45:46 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 67767 invoked by uid 99); 13 Mar 2014 18:45:45 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Mar 2014 18:45:45 +0000
Date: Thu, 13 Mar 2014 18:45:45 +0000 (UTC)
From: "Karthik Kambatla (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12699860.1394484847987.62169.1394736345539@arcas>
In-Reply-To: <JIRA.12699860.1394484847987@arcas>
References: <JIRA.12699860.1394484847987@arcas>
Subject: [jira] [Commented] (YARN-1811) RM HA: AM link broken if the AM is
 on nodes other than RM
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933866#comment-13933866 ] 

Karthik Kambatla commented on YARN-1811:
----------------------------------------

Thanks Robert.

Comments:
# WebAppUtils#getProxyHostsAndPortsForAmFilter is a little dense for my liking. We should probably add comments for the various ifs and fors :)
# Nit: Okay with not fixing it. I find using Joiner more readable. 
{code}
    StringBuilder sb = new StringBuilder();
    for (String proxy : proxies) {
      sb.append(proxy.split(":")[0]).append(AmIpFilter.PROXY_HOSTS_DELIMITER);
    }
    sb.setLength(sb.length() - 1);
{code}
# AmIpFilter has a couple of public fields we are removing. We can leave them there for compatibility sake (in theory) and may be deprecate them as well. If others involved think okay, we should probably just make AmIpFilter @Private. 
# AmIpFilter#findRedirectUrl - we could use a Map<String (host:port), proxyUriBase>, so we don't need the following for loop.
{code}
      for (String proxyUriBase : proxyUriBases) {
        try {
          URL url = new URL(proxyUriBase);
          if (host.equals(url.getHost() + ":" + url.getPort())) {
            addr = proxyUriBase;
            break;
          }
        } catch(MalformedURLException e) {
          // ignore
        }
      }
{code}
# Also, we should at least log the MalformedURLException above and not add to the map. 

> RM HA: AM link broken if the AM is on nodes other than RM
> ---------------------------------------------------------
>
>                 Key: YARN-1811
>                 URL: https://issues.apache.org/jira/browse/YARN-1811
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.3.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: YARN-1811.patch, YARN-1811.patch, YARN-1811.patch
>
>
> When using RM HA, if you click on the "Application Master" link in the RM web UI while the job is running, you get an Error 500:



--
This message was sent by Atlassian JIRA
(v6.2#6252)