Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 14 Mar 2014 23:24:43 +0000 (UTC)
From: "Tsuyoshi OZAWA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12686372.1388014079124.73961.1394839483511@arcas>
In-Reply-To: <JIRA.12686372.1388014079124@arcas>
References: <JIRA.12686372.1388014079124@arcas>
Subject: [jira] [Commented] (YARN-1536) Cleanup: Get rid of
 ResourceManager#get*SecretManager() methods and use the RMContext methods
 instead
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935811#comment-13935811 ] 

Tsuyoshi OZAWA commented on YARN-1536:
--------------------------------------

+1, LGTM. Confirmed to pass tests correctly on local. TestRMRestart's failure has been already filed as YARN-1830. [~kkambatl], can you also check it?

> Cleanup: Get rid of ResourceManager#get*SecretManager() methods and use the RMContext methods instead
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1536
>                 URL: https://issues.apache.org/jira/browse/YARN-1536
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.3.0
>            Reporter: Karthik Kambatla
>            Assignee: Anubhav Dhoot
>            Priority: Minor
>              Labels: newbie
>         Attachments: yarn-1536.patch
>
>
> Both ResourceManager and RMContext have methods to access the secret managers, and it should be safe (cleaner) to get rid of the ResourceManager methods.


--
This message was sent by Atlassian JIRA
(v6.2#6252)