hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1867) NPE while fetching apps via the REST API
Date Tue, 25 Mar 2014 20:33:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947099#comment-13947099

Karthik Kambatla commented on YARN-1867:

Good catch. The fix looks good to me. 

bq. The code in the main ResourceManager has become unmaintenable after the introduction of
the active-services.
Agree. I have been thinking of it too. I think we should just move RMActiveServices into its
own file - that would force us to clean up the unwieldy mess it has become. Filed YARN-1874
to do the same. Feel free to pick it up. I can take a stab, may be in a week or two.

That said, it would be nice to address all the cleanup changes there, particularly if they
are not related to the bug we are fixing here. 
+    private DelegationTokenRenewer delegationTokenRenewer;
+    private EventHandler<SchedulerEvent> schedulerDispatcher;
+    private ApplicationMasterLauncher applicationMasterLauncher;
+    private ContainerAllocationExpirer containerAllocationExpirer;
+    private boolean recoveryEnabled;

Also, we should probably limit the formatting changes to the files that have non-formatting
changes. May be leave out RMContextImpl?

> NPE while fetching apps via the REST API
> ----------------------------------------
>                 Key: YARN-1867
>                 URL: https://issues.apache.org/jira/browse/YARN-1867
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Karthik Kambatla
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Blocker
>              Labels: rest_api
>         Attachments: YARN-1867-20140325.txt
> We ran into the following NPE when fetching applications using the REST API:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.yarn.server.security.ApplicationACLsManager.checkAccess(ApplicationACLsManager.java:104)
> at org.apache.hadoop.yarn.server.resourcemanager.webapp.RMWebServices.hasAccess(RMWebServices.java:123)
> at org.apache.hadoop.yarn.server.resourcemanager.webapp.RMWebServices.getApps(RMWebServices.java:418)
> {noformat}

This message was sent by Atlassian JIRA

View raw message