hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1833) TestRMAdminService Fails in trunk and branch-2
Date Fri, 14 Mar 2014 19:56:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935546#comment-13935546
] 

Jonathan Eagles commented on YARN-1833:
---------------------------------------

[~mdesai], instead of removing the check, could we investigate using UserGroupInformation.createUserForTesting.
This will allow us to isolate the developer environment as a requirement to the correctness
of the test.

> TestRMAdminService Fails in trunk and branch-2
> ----------------------------------------------
>
>                 Key: YARN-1833
>                 URL: https://issues.apache.org/jira/browse/YARN-1833
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>              Labels: Test
>         Attachments: YARN-1833.patch
>
>
> In the test testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider,
the following assert is not needed.
> {code}
> Assert.assertTrue(groupWithInit.size() != groupBefore.size());
> {code}
> As the assert takes the default groups for groupWithInit (which in my case are users,
sshusers and wheel), it fails as the size of both groupWithInit and groupBefore are same.
> I do not think we need to have this assert here. Moreover we are also checking that the
groupInit does not have the userGroups that are in the groupBefore so removing the assert
may not be harmful.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message