hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1787) yarn applicationattempt/container print wrong usage information
Date Fri, 07 Mar 2014 06:36:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923621#comment-13923621
] 

Zhijie Shen commented on YARN-1787:
-----------------------------------

bq. I am fairly sure you broke bin/yarn appliciation etc after the patch, can you please verify?
bq. The patch looks fine overall other than bin/yarn changes.

This patch doesn't modify bin/yarn. YARN-967 introduced the following trick in bin/yarn:
{code}
+  set -- $COMMAND $@
{code}
which takes "application/applicationattempt/container" as the first arg. So in ApplicationCLI,
we need to parse one more arg.

According to my local test, "yarn application" works fine after the patch, as well "yarn applicationattempt"
and "yarn container".

bq. Ideally, we should split the CLI into separate classes for app, appattempts etc. Will
file a ticket.

I've noticed this as well, and I agree it's the ideal solution. Unfortunately, the previous
changes of getting/listing appattempt(s)/container(s) are all in the ApplicationCLI, therefore,
I keep the change the same class. Another choice is to rename ApplicationCLI to some name
that can indicate app, appattempt and container inclusively, but I'm not sure it is a compatible
change or not, if users invoke ApplicationCLI programmatically instead of using shell script.
Thoughts?




> yarn applicationattempt/container print wrong usage information
> ---------------------------------------------------------------
>
>                 Key: YARN-1787
>                 URL: https://issues.apache.org/jira/browse/YARN-1787
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: ApplicationCLI.java.rej, YARN-1787.1.patch, YARN-1787.2.patch
>
>
> yarn applicationattempt prints:
> {code}
> Invalid Command Usage : 
> usage: application
>  -appStates <States>             Works with -list to filter applications
>                                  based on input comma-separated list of
>                                  application states. The valid application
>                                  state can be one of the following:
>                                  ALL,NEW,NEW_SAVING,SUBMITTED,ACCEPTED,RUN
>                                  NING,FINISHED,FAILED,KILLED
>  -appTypes <Types>               Works with -list to filter applications
>                                  based on input comma-separated list of
>                                  application types.
>  -help                           Displays help for all commands.
>  -kill <Application ID>          Kills the application.
>  -list <arg>                     List application attempts for aplication
>                                  from AHS.
>  -movetoqueue <Application ID>   Moves the application to a different
>                                  queue.
>  -queue <Queue Name>             Works with the movetoqueue command to
>                                  specify which queue to move an
>                                  application to.
>  -status <Application ID>        Prints the status of the application.
> {code}
> yarn container prints:
> {code}
> Invalid Command Usage : 
> usage: application
>  -appStates <States>             Works with -list to filter applications
>                                  based on input comma-separated list of
>                                  application states. The valid application
>                                  state can be one of the following:
>                                  ALL,NEW,NEW_SAVING,SUBMITTED,ACCEPTED,RUN
>                                  NING,FINISHED,FAILED,KILLED
>  -appTypes <Types>               Works with -list to filter applications
>                                  based on input comma-separated list of
>                                  application types.
>  -help                           Displays help for all commands.
>  -kill <Application ID>          Kills the application.
>  -list <arg>                     List application attempts for aplication
>                                  from AHS.
>  -movetoqueue <Application ID>   Moves the application to a different
>                                  queue.
>  -queue <Queue Name>             Works with the movetoqueue command to
>                                  specify which queue to move an
>                                  application to.
>  -status <Application ID>        Prints the status of the application.
> {code}
> Both commands print irrelevant yarn application usage information.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message