hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1781) NM should allow users to specify max disk utilization for local disks
Date Thu, 06 Mar 2014 01:03:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921804#comment-13921804
] 

Xuan Gong commented on YARN-1781:
---------------------------------

The patch looks fine to me.
One nit:
{code}
+    diskUtilizationPercCutoff = utilizationPercCutOff;
+    diskUtilizationSpaceCutoff = utilizationSpaceCutOff;
+    diskUtilizationPercCutoff = 
+        utilizationPercCutOff < 0.0F ? 0.0F : utilizationPercCutOff;
+    diskUtilizationPercCutoff = 
+        utilizationPercCutOff > 100.0F ? 100.0F : diskUtilizationPercCutoff;
+    diskUtilizationSpaceCutoff = 
+        utilizationSpaceCutOff < 0 ? 0 : utilizationSpaceCutOff;
{code}
Maybe we can simplify a little bit.
{code}
    diskUtilizationPercCutoff =
        utilizationPercCutOff < 0.0F ? 0.0F
            : utilizationPercCutOff > 100.0F ? 100.0F : utilizationPercCutOff;
    diskUtilizationSpaceCutoff =
        utilizationSpaceCutOff < 0 ? 0 : utilizationSpaceCutOff;
{code}

> NM should allow users to specify max disk utilization for local disks
> ---------------------------------------------------------------------
>
>                 Key: YARN-1781
>                 URL: https://issues.apache.org/jira/browse/YARN-1781
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: apache-yarn-1781.0.patch, apache-yarn-1781.1.patch
>
>
> This is related to YARN-257(it's probably a sub task?). Currently, the NM does not detect
full disks and allows full disks to be used by containers leading to repeated failures. YARN-257
deals with graceful handling of full disks. This ticket is only about detection of full disks
by the disk health checkers.
> The NM should allow users to set a maximum disk utilization for local disks and mark
disks as bad once they exceed that utilization. At the very least, the NM should at least
detect full disks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message