hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mayank Bansal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1690) sending ATS events from Distributed shell
Date Fri, 14 Mar 2014 15:26:46 GMT

    [ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935148#comment-13935148

Mayank Bansal commented on YARN-1690:

Thanks [~zjshen] for the review

bq. 1. Catch Exception and merge the duplicate handling.

bq. 2. Call it timeline client, and similar for the following code.

bq. 3. Is the following the related change
This is done due to logging issue, so its good to put it.

bq. 4. Don't create a new config, but use the existing one.
It has to be created, there is no previous config 

bq. 5. Call it DS_CONTAINER? Do not confuse it with the generic information.

bq. 6. Entity type is different from event type. Call it DS_APPLICATION_ATTEMPT?

bq. 7. Event type is not set

bq. 8. Correct "STatus"

bq. 9. Can you add user as the primary filter?

bq. 10. In general, it doesn't make sense to record the information that the generic history
service has already captured, such as the other info for container. It's per-framework data,
such that it's better to record some DS specific information.
chaged the names

bq. 11. Need more assertion. For example, test both container and attempt entities.

bq. 12. Mark it @Private as well

bq. 13. Correct comment? It seems you choose to set default AHS address, and don't understand
why it is related to YARN_MINICLUSTER_FIXED_PORTS.

> sending ATS events from Distributed shell 
> ------------------------------------------
>                 Key: YARN-1690
>                 URL: https://issues.apache.org/jira/browse/YARN-1690
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch

This message was sent by Atlassian JIRA

View raw message