hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1536) Cleanup: Get rid of ResourceManager#get*SecretManager() methods and use the RMContext methods instead
Date Tue, 18 Mar 2014 07:40:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938927#comment-13938927
] 

Karthik Kambatla commented on YARN-1536:
----------------------------------------

Looks good. Few nits:
# May be not include the following spurious change.
{code}
-    rmContext.setHAServiceState(HAServiceState.STOPPING);
+    this.rmContext.setHAServiceState(HAServiceState.STOPPING);
{code}
# More than 80 chars at a few places
# Indentation mis-alignment between method parameters on different lines at a couple of places

> Cleanup: Get rid of ResourceManager#get*SecretManager() methods and use the RMContext
methods instead
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1536
>                 URL: https://issues.apache.org/jira/browse/YARN-1536
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.3.0
>            Reporter: Karthik Kambatla
>            Assignee: Anubhav Dhoot
>            Priority: Minor
>              Labels: newbie
>         Attachments: yarn-1536.patch
>
>
> Both ResourceManager and RMContext have methods to access the secret managers, and it
should be safe (cleaner) to get rid of the ResourceManager methods.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message