Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6B0610FC2 for ; Wed, 5 Feb 2014 23:00:16 +0000 (UTC) Received: (qmail 41394 invoked by uid 500); 5 Feb 2014 23:00:14 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 41290 invoked by uid 500); 5 Feb 2014 23:00:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 41238 invoked by uid 99); 5 Feb 2014 23:00:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 23:00:12 +0000 Date: Wed, 5 Feb 2014 23:00:12 +0000 (UTC) From: "Zhijie Shen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1635) Implement a Leveldb based ApplicationTimelineStore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892722#comment-13892722 ] Zhijie Shen commented on YARN-1635: ----------------------------------- [~billie.rinaldi], thanks for the patch. I have a quick look at it. Here're my comments. I still need more time to took into leveldb details. 1. Should we include ATSImport into the code base? As users are not supposed to send the entity directly to the store, aren't the? 2. It's better to use IOUtils.cleanup to close all the Closable objects. 3. ApplicationTimelineStore APIs should allow IOException. 4. Trim the string first {code} + s = s.toUpperCase(); {code} 5. Should we define some meaningful error code? > Implement a Leveldb based ApplicationTimelineStore > -------------------------------------------------- > > Key: YARN-1635 > URL: https://issues.apache.org/jira/browse/YARN-1635 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Vinod Kumar Vavilapalli > Assignee: Billie Rinaldi > Attachments: YARN-1635.1.patch, YARN-1635.2.patch, YARN-1635.3.patch, YARN-1635.4.patch, YARN-1635.5.patch, YARN-1635.6.patch, YARN-1635.7.patch > > > As per the design doc, we need a levelDB + local-filesystem based implementation to start with and for small deployments. -- This message was sent by Atlassian JIRA (v6.1.5#6160)