hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
Date Thu, 27 Feb 2014 08:50:19 GMT

    [ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914223#comment-13914223

Xuan Gong commented on YARN-1765:

bq. No need for RMAppManager.getRMContext(). The context is already available in the constructor,
just cache it.


bq. MockRM changes are completely unnecessary, the API you want already exists


bq. Move the test to a failover package? We should move all tests related to HA/fail-over
to a new package. It's getting increasingly crowded in the base package.

Can we do this at separate ticket ? It may need some time to figure out the proper directory
to have all HA/fail-over tests

bq. Document all the tests in the test-file and add timeouts.


bq. Doesn't like all the tests have the right names. Fix them to be more apt.


bq. In failOver* methods, assert the expected app and app-attempt state before killing the
app. Also assert app-state immediately after fail-over succeeds.


bq. Validate the response from killApp() method in all tests. Specifically validate KillApplicationResponse.getIsKillCompleted().


bq. There is one other important test that we need to write as follow


> Write test cases to verify that killApplication API works in RM HA
> ------------------------------------------------------------------
>                 Key: YARN-1765
>                 URL: https://issues.apache.org/jira/browse/YARN-1765
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-1765.1.patch, YARN-1765.2.patch

This message was sent by Atlassian JIRA

View raw message