hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1732) Change types of related entities and primary filters in ATSEntity
Date Fri, 21 Feb 2014 23:19:19 GMT

    [ https://issues.apache.org/jira/browse/YARN-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908977#comment-13908977

Vinod Kumar Vavilapalli commented on YARN-1732:

Looks good to me too, +1.

> Change types of related entities and primary filters in ATSEntity
> -----------------------------------------------------------------
>                 Key: YARN-1732
>                 URL: https://issues.apache.org/jira/browse/YARN-1732
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-1732.1.patch, YARN-1732.2.patch, YARN-1732.3.patch
> The current types Map<String, List<String>> relatedEntities and Map<String,
Object> primaryFilters have issues.  The List<String> value of the related entities
map could have multiple identical strings in it, which doesn't make sense. A more major issue
is that we cannot allow primary filter values to be overwritten, because otherwise we will
be unable to find those primary filter entries when we want to delete an entity (without doing
a nearly full scan).
> I propose changing related entities to Map<String, Set<String>> and primary
filters to Map<String, Set<Object>>.  The basic methods to add primary filters
and related entities are of the form add(key, value) and will not need to change.

This message was sent by Atlassian JIRA

View raw message