hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-1730) Leveldb timeline store needs simple write locking
Date Tue, 18 Feb 2014 22:17:21 GMT

     [ https://issues.apache.org/jira/browse/YARN-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zhijie Shen updated YARN-1730:
------------------------------

    Attachment: YARN-1730.2.patch

Billie, thanks for the patch! It looks good to me in general. It can help to reduce the synchronization
between read/write operations.

Based on the patch, I made some change to use ReentrantLock directly instead of creating CountReentrantLock,
as ReentrantLock has HoldCount to do what you want. In addition, I cleaned unnecessary import
in TestLeveldbApplicationTimelineStore, add some more comments on code.

> Leveldb timeline store needs simple write locking
> -------------------------------------------------
>
>                 Key: YARN-1730
>                 URL: https://issues.apache.org/jira/browse/YARN-1730
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-1730.1.patch, YARN-1730.2.patch
>
>
> The actual data writes are performed atomically in a batch, but a lock should be held
while identifying a start time for the entity, which precedes every write.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message