hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1685) [YARN-321] Logs link can be null so avoid NPE
Date Thu, 13 Feb 2014 00:35:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899837#comment-13899837
] 

Zhijie Shen commented on YARN-1685:
-----------------------------------

Hi Mayank, some comments on the patch:

1. Please do not return "#" in the util method, which may not make sense to all callers. Instead
do null check in the related web page classes.
{code}
+	if(url == null){
+		return "#";
+	}
{code}

2. Please fix the test failures. And in TestRMContainerImpl, please assert both the urls of
container at running and completed states.

> [YARN-321] Logs link can be null so avoid NPE
> ---------------------------------------------
>
>                 Key: YARN-1685
>                 URL: https://issues.apache.org/jira/browse/YARN-1685
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>             Fix For: YARN-321
>
>         Attachments: YARN-1685-1.patch
>
>
> https://issues.apache.org/jira/browse/YARN-1413?focusedCommentId=13866416&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13866416
> https://issues.apache.org/jira/browse/YARN-1413?focusedCommentId=13866844&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13866844



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message